Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix mounting utility usage of pinia (fixes charts form components) #18430

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Jun 21, 2024

This has changed multiple times in descendant branches (#18299, #18315, #18429 ), so this is a flattened, cleaned up version for application against 24.0.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

changed multiple times in descendant branches so this is a flattened,
cleaned up version for application against 24.0.
@dannon dannon marked this pull request as ready for review June 21, 2024 17:22
@mvdbeek mvdbeek merged commit 2257c22 into galaxyproject:release_24.0 Jun 24, 2024
27 of 29 checks passed
@itisAliRH itisAliRH deleted the fix-chargs-24.0 branch June 27, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants